Mark & unmake simitone in piano roll

[lsdfjksdjfh (Anon)]

[seablade]

Curious, what is the goal of this?

  Seablade

[lsdfjksdjfh (Anon)]

@seablade

Curious

: D
easy find scale and chord position

[x42 (Robin Gareus)]

There is a prototype available:

Piano roll scale note indicators

In any case feature request belong on tracker.ardour.org.

[lsdfjksdjfh (Anon)]

thanks @x42
is a perfect patch
but why ardour team dont use this ???

[x42 (Robin Gareus)]

@lsdfjksdjfh

but why ardour team dont use this ???

We will. – See the comments on the pull-request.

We already have infrastructure prepared for this which the patch does not yet use.
So in order to make this maintainable and avoid duplicating work, the patch needs to be consolidated a bit before we accept it.

But yes, it’s about 90% there.

[paul (Paul Davis)]

It’s also missing all the Messaien octatonic scales, and Locrian flat-2. Unacceptable with these limitations.

[x42 (Robin Gareus)]

@paul

It’s also missing all the Messaien octatonic scales,

precisely. From the PR:

• I think hardcoding scales is not a good idea, Scales should be dynamically loaded and extensible. So I’d not define enums for root notes and scales. That is limiting down the road.
• The code should eventually be consolidated with libs/surfaces/push2/scale.cc

Also ParameterDescriptor::midi_note_name() should be used to make note names translatable. e.g. German uses “H” instead of “B” etc.

Furthermore it’d be nice to have this not per track but globally for all tracks, and allow to change the scale at given points on the timeline, since many compositions change key.